Help reviewing comment translation (German -> English)

l10n
#1

Hi,

Could someone review this Google translation of comment from German to
English ? (see the attached file)

Thanks.

Kaplan

#2

Hi,

Hi,

Could someone review this Google translation of comment from German to
English ? (see the attached file)

No attached file because of ml.

#3

diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index 979591a..a33a5a2 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -102,7 +102,7 @@ sal_Bool ScTabViewShell::GetFunction( String& rFuncStr,
sal_uInt16 nErrCode )
                 aStr += '0';
             else
             {
- // Anzahl im Standardformat, die anderen nach
Cursorposition
+ // Number in the standard format, the other on the cursor
position
                 SvNumberFormatter* pFormatter = pDoc->GetFormatTable();
                 sal_uInt32 nNumFmt = 0;
                 if ( eFunc != SUBTOTAL_FUNC_CNT && eFunc !=
SUBTOTAL_FUNC_CNT2 )
@@ -137,7 +137,7 @@ sal_Bool ScTabViewShell::GetFunction( String& rFuncStr,
sal_uInt16 nErrCode )

-// Funktionen, die je nach Selektion disabled sind
+// Functions that are disabled, depending on the selection
// Default:
// SID_DELETE,
// SID_DELETE_CONTENTS,
@@ -223,8 +223,10 @@ void ScTabViewShell::GetState( SfxItemSet& rSet )

             case SID_SEARCH_OPTIONS:
                 {
- sal_uInt16 nOptions = 0xffff; // alles erlaubt
- // wenn ReadOnly, kein
Ersetzen:
+ // alles erlaubt
+ sal_uInt16 nOptions = 0xffff;

#4

Hi :slight_smile:
It does kinda make grammatical sense but it's not clear what is really meant.  For example

"Number in the standard format, the other on the cursor position" begs the question "the other what?".  The 1st thing talks about format and the 2nd talks about position.  Normally one would distinguish both things by position or both by formats.  Does it make sense in German?  Hopefully it becomes clear when you see context.  Perhaps coding provides the context.

"alles erlaubt" = all ??

"Table for Basic is 1-based" probably makes sense to devs but perhaps meant to say that the table is to base 1, but that doesn't sound plausible.  Binary is base-2.  Decimal is base-10.  There is probably some special notation but i've just written it as it would be spoken.  Hopefully i'm off track anyway and devs would understand.

"  // disable if already set default" perhaps should be "  // disable if already set to default" or "  // disable if already set as default".  For the 1st suggestion it doesn't actually tell you anything about what the default value is so it's a more generic answer.  The 2nd case is a statement that the attempt to change whatever is disabled because the new value is already the same as the current default.

" // NumberFormat generate value from Value and Language and bagging" probably needs to be "generates".  Not sure what "bagging" means.  Perhaps "packaging" or "containing"?

Does "nur" really mean "only" rather than "not" or something else negative?

Errr, i have missed out all the ones that seemed perfect.

Good work even on the ones i picked out.  Chances are that the devs would understand those ones too. 
Regards from
Tom :slight_smile:

#5

Hi :slight_smile:
It does kinda make grammatical sense but it's not clear what is really meant. For example

"Number in the standard format, the other on the cursor position" begs the question "the other what?". The 1st thing talks about format and the 2nd talks about position. Normally one would distinguish both things by position or both by formats. Does it make sense in German? Hopefully it becomes clear when you see context. Perhaps coding provides the context.

"alles erlaubt" = all ??

"all allowed" or "all permitted" or better "Anything goes"

"Table for Basic is 1-based" probably makes sense to devs but perhaps meant to say that the table is to base 1, but that doesn't sound plausible. Binary is base-2. Decimal is base-10. There is probably some special notation but i've just written it as it would be spoken. Hopefully i'm off track anyway and devs would understand.

I think "1-based" is a technical term in Base.

" // disable if already set default" perhaps should be " // disable if already set to default" or " // disable if already set as default". For the 1st suggestion it doesn't actually tell you anything about what the default value is so it's a more generic answer. The 2nd case is a statement that the attempt to change whatever is disabled because the new value is already the same as the current default.

" // NumberFormat generate value from Value and Language and bagging" probably needs to be "generates". Not sure what "bagging" means. Perhaps "packaging" or "containing"?

"eintüten" is here some kind of colloquial and means "to box" or "to
finish" or "to put".

For me as a non developer it is a different grammatical sense by
"NumberFormat generate value" to the German explanation. The English
sentence means: "The NumberFormat generates the Value from Value and
Language" but it means in German: You (or sb. else) generate the
NumberFormat Value from Value and Language".

So it would be "Generate NumberFormat Value from Value and Language and
box it."

Does "nur" really mean "only" rather than "not" or something else negative?

It means "only"

#6

Hi :slight_smile:
I'm really sorry i dropped the ball on this!!  Has it been solved?  I'm not sure what positive suggestions i could have made to be honest. :(  It's good to hear that 1-based would make sense to someone experienced with Base.  The first place where i think i understand enough is the

" // NumberFormat generates it's value from Value and Language and that completes it's task.  "

but i think i was helped there because it's exactly what you said. 
Many apols and regards from
Tom :slight_smile:

#7

Already in master, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=447a924c115a86e96e91b24d744af70f97efde72

Thanks for the review/comments.

Kaplan

#8

Hi :slight_smile:
Ah, that looks good in there.  It makes sense now
Regards from
Tom :slight_smile: