i18ned entry of numbers within LibreOffice

l10n
#1

(Please keep me and Zolnai in CC in this discussion. Thanks.)

In the context of https://gerrit.libreoffice.org/1994

Zolnai is contributing a nice feature to LibreOffice Base, but in the
review of the patch I'm hitting what should be a simple issue: how to
"get" a number (or special value All) from the user?

My assumption is that in some locales we should allow the user to use
other digits that the ASCII 0-9 (byte values 0x30 to 0x39). I *think*
Zolnai's patch does this right, but could someone please check it out
from this POV? Thanks in advance. Maybe there is even simpler (as in
"more code reuse instead of reinventing the wheel"), and there is a
vcl class that we can "just" derive from to get a number entry box?
But we also need a special value "All", so maybe Zolnai did it the
simplest way possible already :slight_smile:

One question I'm less sure about:

In the non-ASCII digit locales, is there any reason to reject ASCII
digits? Should we do that?

In all these questions, if we do "the same as the other number entries
in LibreOffice (e.g. font size, configuration of undo stack depth,
...)", then I'm happy. I'm not trying to do better.

Thanks in advance for the help,

#2

Hi Lionel,

Zolnai is contributing a nice feature to LibreOffice Base, but in the
review of the patch I'm hitting what should be a simple issue: how to
"get" a number (or special value All) from the user?

See also my previous reply to Zolnai where I mentioned NumericBox and
the NumericFormatter used for control fields.

The right place to extend functionality for native numbers is there.

But we also need a special value "All", so maybe Zolnai did it the
simplest way possible already :slight_smile:

I think "All" could be mapped in this case to the maximum allowed value,
couldn't it?

One question I'm less sure about:

In the non-ASCII digit locales, is there any reason to reject ASCII
digits? Should we do that?

No, I don't think we should. IMHO there is no real reason to reject
ASCII digits. Which btw is also how numeric input in Calc is treated,
both ASCII and native numbers are allowed.

  Eike